From: Carlo Arenas <carenas@gmail.com>
Date: Sat, 28 Aug 2021 09:45:57 GMT
Subject: Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic
Message-ID: <CAPUEspgDbi1v32p+H=afZSDVOo_VpJzKn7bU8_s+fPJxm=mtBQ@mail.gmail.com>
In-Reply-To: <xmqq1r6ebyo5.fsf@gitster.g>

On Fri, Aug 27, 2021 at 10:11 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> One thing I noticed is that simple-ipc.h can disable itself
> altogether with "#ifdef SUPPORTS_SIMPLE_IPC", so the unconditional
> use of "enum ipc_active_state" by fsmonitor-ipc.h would still be a
> problem.

That is why we also need an additional patch[1] to be able to build
(at least in macOS).

in windows additional changes are required, but I suspect that
configuration is probably not expected.

> fsmonitor-ipc.h is included even in help.c so it seems
> that with this topic, you practically will not get a working Git at
> all with -pedantic when SUPPORTS_SIMPLE_IPC is not true.

not sure if I understand the logic here, but there is a "mock" daemon
that is used in the platforms that don't have support that will be
available then (even if it just refuses to start), and that is still
IMHO a working git configuration.

Carlo

[1] https://lore.kernel.org/git/20210817082310.2157-1-carenas@gmail.com/