git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 9, 2021, 16:49 UTC
Message-ID
<xmqqpmumftry.fsf@gitster.g>
In-Reply-To
<42dce285-9599-4c7c-d351-44c1e338337e@jeffhostetler.com>
Jeff Hostetler <git@jeffhostetler.com> writes:
Show 18 quoted lines
> On 8/9/21 2:30 AM, Carlo Marcelo Arenas Belón wrote:
>> seen with both clang 12 and gcc 11 in seen (including jh/builtin-fsmonitor)
>> as of a5a42b9f76 (from Jul 1)
>> it should be squashed into the corresponding patch from the series
>> as shown
>> in the subject and reroll IMHO; notice Junio also has some bandaid sparse
>> fixes for t/helper/test-touch.c that should be included.
>> a similar additional fix for C89 compatibility to be send as a reply
>> later
>> Carlo Marcelo Arenas Belón (2):
>>    fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon
>>    fixup! fsmonitor--daemon: implement handle_client callback
>>   builtin/fsmonitor--daemon.c | 2 +-
>>   fsmonitor-ipc.h             | 2 ++
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>> 
>
> Thanks!
Thanks, both.  

Jeff, I understand that this is planned to be rerolled post release, so I'll not touch these fixups and let yuou worry about them ;-)

Previous: Jeff HostetlerNext: Carlo Arenas
Message 6 of 13 in “fsmonitor: fixup to avoid warnings from pedantic”
  1. 0/2 fsmonitor: fixup to avoid warnings from pedanticCarlo Marcelo Arenas Belón, Aug 9, 2021
  2. 1/2 fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemonCarlo Marcelo Arenas Belón, Aug 9, 2021
  3. 2/2 fixup! fsmonitor--daemon: implement handle_client callbackCarlo Marcelo Arenas Belón, Aug 9, 2021
  4. test-path-utils: use a C89 compatible format for double printfCarlo Marcelo Arenas Belón, Aug 9, 2021
  5. Jeff HostetlerAug 9, 2021
  6. Junio C HamanoAug 9, 2021
  7. Carlo ArenasAug 10, 2021
  8. Jeff HostetlerAug 10, 2021
  9. Jeff HostetlerAug 10, 2021
  10. Junio C HamanoAug 27, 2021
  11. Carlo ArenasAug 27, 2021
  12. Junio C HamanoAug 27, 2021
  13. Carlo ArenasAug 28, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.