git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 27, 2021, 17:11 UTC
Message-ID
<xmqq1r6ebyo5.fsf@gitster.g>
In-Reply-To
<CAPUEsphe0N6w_qCTAp46YPH7vBj2dkJa9kOm2HaixkFkVuk3GA@mail.gmail.com>
Carlo Arenas <carenas@gmail.com> writes:
Show 13 quoted lines
> On Thu, Aug 26, 2021 at 10:37 PM Junio C Hamano <gitster@pobox.com> wrote:
>> Here is what I had to do to work around
>>
>>  https://github.com/git/git/runs/3438543601?check_suite_focus=true#step:5:136
>
> correct; that was 1/2 of the fixups I proposed and were waiting for the reroll.
>
> interesting that the job was able to build without 2/2[1] but it might
> be because clang is even more pedantic.
>
> Carlo
>
> [1] https://lore.kernel.org/git/20210809063004.73736-3-carenas@gmail.com/

One thing I noticed is that simple-ipc.h can disable itself altogether with "#ifdef SUPPORTS_SIMPLE_IPC", so the unconditional use of "enum ipc_active_state" by fsmonitor-ipc.h would still be a problem. fsmonitor-ipc.h is included even in help.c so it seems that with this topic, you practically will not get a working Git at all with -pedantic when SUPPORTS_SIMPLE_IPC is not true.

Previous: Carlo ArenasNext: Carlo Arenas
Message 12 of 13 in “fsmonitor: fixup to avoid warnings from pedantic”
  1. 0/2 fsmonitor: fixup to avoid warnings from pedanticCarlo Marcelo Arenas Belón, Aug 9, 2021
  2. 1/2 fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemonCarlo Marcelo Arenas Belón, Aug 9, 2021
  3. 2/2 fixup! fsmonitor--daemon: implement handle_client callbackCarlo Marcelo Arenas Belón, Aug 9, 2021
  4. test-path-utils: use a C89 compatible format for double printfCarlo Marcelo Arenas Belón, Aug 9, 2021
  5. Jeff HostetlerAug 9, 2021
  6. Junio C HamanoAug 9, 2021
  7. Carlo ArenasAug 10, 2021
  8. Jeff HostetlerAug 10, 2021
  9. Jeff HostetlerAug 10, 2021
  10. Junio C HamanoAug 27, 2021
  11. Carlo ArenasAug 27, 2021
  12. Junio C HamanoAug 27, 2021
  13. Carlo ArenasAug 28, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.