Re: [RFC PATCH 1/2] remote: move remote group resolution to remote.c
Show 7 quoted lines
> > +int get_remote_group(const char *key, const char *value,
> > + const struct config_context *ctx UNUSED,
> > + void *priv);
>
> It is dubious to carry UNUESD over to an external declaration in a
> public header file, unless it is a "static inline" definition that
> comes with the implementation.
Show 8 quoted lines
>
> Other than that, move looks correct and it is generally a good idea.
>
> When moving functions and types that have been private to the
> implementation of a subsystem to public namespace, we need to be
> careful to consider if the names of these things are specific
> enough. With "remote_group" in them, they are all good as-is in
> this case, and can go public without giving them "better" names.
>
> Thanks.
>