Re: [RFC PATCH v3 2/2] push: support pushing to a remote group
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 27, 2026, 22:18 UTC
- Message-ID
- <xmqqse9kj4rh.fsf@gitster.g>
- In-Reply-To
- <20260325190906.1153080-3-usmanakinyemi202@gmail.com>
Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
Show 36 quoted lines
> t/meson.build | 1 + > t/t5566-push-group.sh | 150 ++++++++++++++++++++++++++++++++++++ > ... > diff --git a/t/t5566-push-group.sh b/t/t5566-push-group.sh > new file mode 100755 > index 0000000000..b9962946c7 > --- /dev/null > +++ b/t/t5566-push-group.sh > @@ -0,0 +1,150 @@ > +#!/bin/sh > + > +test_description='push to remote group' > + > +. ./test-lib.sh > + > +test_expect_success 'setup' ' > + for i in 1 2 3 > + do > + git init --bare dest-$i.git && > + git -C dest-$i.git symbolic-ref HEAD refs/heads/not-a-branch || > + return 1 > + done && > + test_tick && > + git commit --allow-empty -m "initial" && > + git config set remote.remote-1.url "file://$(pwd)/dest-1.git" && > + git config set remote.remote-1.fetch "+refs/heads/*:refs/remotes/remote-1/*" && > + git config set remote.remote-2.url "file://$(pwd)/dest-2.git" && > + git config set remote.remote-2.fetch "+refs/heads/*:refs/remotes/remote-2/*" && > + git config set remote.remote-3.url "file://$(pwd)/dest-3.git" && > + git config set remote.remote-3.fetch "+refs/heads/*:refs/remotes/remote-3/*" && > + git config set remotes.all-remotes "remote-1 remote-2 remote-3" > +' > + > +test_expect_success 'push to remote group updates all members correctly' ' > + git push all-remotes HEAD:refs/heads/main && > + git rev-parse HEAD >expect &&
These tests will break rather badly at Git 3.0 boundary, because the default branch name will be 'main' beyond that point.
It can be visible in
https://github.com/git/git/actions/runs/23667958553/job/68954593675
i.e., linux-breaking-changes job.
I think we can squash in a futureproof fix like this one to the patch.
diff --git c/t/t5566-push-group.sh w/t/t5566-push-group.sh index b9962946c7..32b8c82cea 100755 --- c/t/t5566-push-group.sh +++ w/t/t5566-push-group.sh @@ -2,6 +2,9 @@ test_description='push to remote group' +GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=default +export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME + . ./test-lib.sh test_expect_success 'setup' '