git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH v3 2/2] push: support pushing to a remote group

From
Usman Akinyemi <usmanakinyemi202@gmail.com>
Date
Mar 31, 2026, 22:35 UTC
Message-ID
<CAPSxiM_oSzQvH3w-vnrmGxWkXBhDy6B3JvZyJHBR1=+BMgjytg@mail.gmail.com>
In-Reply-To
<xmqq7bqzu1xh.fsf@gitster.g>
Show 15 quoted lines
>
> I am not convinced that having these two "failure modes" is a good
> thing; I am not convinced that a single failure mode is better,
> either, though X-<.
>
> I would personally have designed to mimic exactly like "git push r1;
> git push r2; ..." would do (not concatenated with "&&" but with
> ";"), which would mean that there is only one single failure mode
> that would not affect interactions with any other remotes, but I
> have no strong arguments to choose that design, other than that it
> would be easy to explain when we later start supporting pushes to
> multiple remotes in parallel, where a failure to talk to one remote
> cannot easily affect interaction with other remotes without getting
> affected by timing issues.
>

I did not think about deciding what approach to pick out of the two, It was just the default i.e the behaviour after adding the changes. I think it makes sense that we have one failure mode incase of multiple remotes in parallel.

Show 9 quoted lines
> > +This means the user is responsible for ensuring that the sequence of
> > +individual pushes makes sense. If `git push r1`` would fail for a given
> > +set of options and arguments, then `git push all-remotes` will fail in
> > +the same way when it reaches r1. The group push does not do anything
> > +special to make a failing individual push succeed.
>
> "when it reaches r1" makes it sound as if the group push then stops
> after that failure, but that is not what we just read in the two
> paragraphs about two failure modes.

hmm, though reading the statement from the beginning makes it clear to me, if `git push r1` will fail, if you `r1` is part of `all-remotes`, if you use `git push all-remotes`, then when it reach `r1`, `r1` will also fail. I think I can make the wording better which should be clear for parallel cases also.

>
Previous: Junio C HamanoNext: Usman Akinyemi
Message 23 of 39 in “push: add support for pushing to remote groups”
  1. 0/2 push: add support for pushing to remote groupsUsman Akinyemi, Mar 5, 2026
  2. 1/2 remote: move remote group resolution to remote.cUsman Akinyemi, Mar 5, 2026
  3. Junio C HamanoMar 6, 2026
  4. Usman AkinyemiMar 9, 2026
  5. 2/2 push: support pushing to a remote groupUsman Akinyemi, Mar 5, 2026
  6. Junio C HamanoMar 7, 2026
  7. Usman AkinyemiMar 9, 2026
  8. Junio C HamanoMar 9, 2026
  9. 0/2 push: add support for pushing to remote groupsUsman Akinyemi, Mar 18, 2026
  10. 1/2 remote: move remote group resolution to remote.cUsman Akinyemi, Mar 18, 2026
  11. 2/2 push: support pushing to a remote groupUsman Akinyemi, Mar 18, 2026
  12. Junio C HamanoMar 18, 2026
  13. Junio C HamanoMar 18, 2026
  14. Junio C HamanoMar 18, 2026
  15. Junio C HamanoMar 19, 2026
  16. Usman AkinyemiMar 25, 2026
  17. Junio C HamanoMar 18, 2026
  18. Usman AkinyemiMar 18, 2026
  19. 0/2 push: add support for pushing to remote groupsUsman Akinyemi, Mar 25, 2026
  20. 1/2 remote: move remote group resolution to remote.cUsman Akinyemi, Mar 25, 2026
  21. 2/2 push: support pushing to a remote groupUsman Akinyemi, Mar 25, 2026
  22. Junio C HamanoMar 25, 2026
  23. Usman AkinyemiMar 31, 2026
  24. Usman AkinyemiMar 31, 2026
  25. Junio C HamanoApr 1, 2026
  26. Junio C HamanoMar 27, 2026
  27. 0/2 push: add support for pushing to remote groupsUsman Akinyemi, Apr 27, 2026
  28. 1/2 remote: move remote group resolution to remote.cUsman Akinyemi, Apr 27, 2026
  29. 2/2 push: support pushing to a remote groupUsman Akinyemi, Apr 27, 2026
  30. Junio C HamanoApr 28, 2026
  31. 0/3 push: add support for pushing to remote groupsUsman Akinyemi, May 3, 2026
  32. 1/3 remote: fix sign-compare warnings in push_cas_optionUsman Akinyemi, May 3, 2026
  33. 2/3 remote: move remote group resolution to remote.cUsman Akinyemi, May 3, 2026
  34. 3/3 push: support pushing to a remote groupUsman Akinyemi, May 3, 2026
  35. Kristoffer HaugsbakkMay 12, 2026
  36. 0/3 push: add support for pushing to remote groupsUsman Akinyemi, May 18, 2026
  37. 1/3 remote: fix sign-compare warnings in push_cas_optionUsman Akinyemi, May 18, 2026
  38. 2/3 remote: move remote group resolution to remote.cUsman Akinyemi, May 18, 2026
  39. 3/3 push: support pushing to a remote groupUsman Akinyemi, May 18, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.