Re: [RFC PATCH v3 0/2] push: add support for pushing to remote groups

From

Junio C Hamano <gitster@pobox.com>

Date

Apr 28, 2026, 01:47 UTC

Message-ID

<xmqq340f26vx.fsf@gitster.g>

In-Reply-To

<20260427140530.856125-1-usmanakinyemi202@gmail.com>

Something like this is needed to workaround -Werror=sign-compare complaints.

diff --git a/builtin/push.c b/builtin/push.c
index 10384f265c..6021b71d66 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -552,7 +552,8 @@ static int push_multiple(struct string_list *list,
 			 const char **refspecs,
 			 int refspec_nr)
 {
-	int i, result = 0;
+	int result = 0;
+	size_t i;
 	struct strvec argv = STRVEC_INIT;
 
 	strvec_push(&argv, "push");
diff --git a/remote.h b/remote.h
index 8ff2bd88fa..7915be3111 100644
--- a/remote.h
+++ b/remote.h
@@ -430,8 +430,8 @@ struct push_cas_option {
 		unsigned use_tracking:1;
 		char *refname;
 	} *entry;
-	int nr;
-	int alloc;
+	size_t nr;
+	size_t alloc;
 };
 
 int parseopt_push_cas_option(const struct option *, const char *arg, int unset);