From: Usman Akinyemi <usmanakinyemi202@gmail.com>
Date: Mon, 09 Mar 2026 00:43:54 GMT
Subject: Re: [RFC PATCH 1/2] remote: move remote group resolution to remote.c
Message-ID: <CAPSxiM83ejdkO5pbtHT5Svsm2iePtuEAA1UE0-H0Txoe0aNckA@mail.gmail.com>
In-Reply-To: <xmqqcy1g25fl.fsf@gitster.g>

> > +int get_remote_group(const char *key, const char *value,
> > +                         const struct config_context *ctx UNUSED,
> > +                         void *priv);
>
> It is dubious to carry UNUESD over to an external declaration in a
> public header file, unless it is a "static inline" definition that
> comes with the implementation.
Noted, thanks.
>
> Other than that, move looks correct and it is generally a good idea.
>
> When moving functions and types that have been private to the
> implementation of a subsystem to public namespace, we need to be
> careful to consider if the names of these things are specific
> enough.  With "remote_group" in them, they are all good as-is in
> this case, and can go public without giving them "better" names.
Noted, thanks.
>
> Thanks.
>