Re: [PATCH v13 5/8] bisect: introduce --no-checkout support into porcelain.
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Aug 3, 2011, 14:09 UTC
- Message-ID
- <CAP8UFD3QvXv_gnAtw3qMCOdDyAUAFMYcf33ieP+HebvTf3SGAg@mail.gmail.com>
- In-Reply-To
- <CAH3AnrpQZJprVtkNH1oeGXADzy1HA20xSTD8Cwpo3=ymOjgYhA@mail.gmail.com>
On Wed, Aug 3, 2011 at 3:24 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
Show 21 quoted lines
> On Wed, Aug 3, 2011 at 10:46 PM, Jon Seymour <jon.seymour@gmail.com> wrote: >> On Wed, Aug 3, 2011 at 3:27 PM, Christian Couder >> <chriscool@tuxfamily.org> wrote: >>> On Tuesday 02 August 2011 16:41:13 Jon Seymour wrote: >>>> On Tue, Aug 2, 2011 at 10:04 PM, Christian Couder >>>> >>>> If I was to do this, I'd prefer to change uses of $BISECT_MODE with a >>>> call to a function bisect_mode() that does the same thing. >>> >>> Yeah, I think it would be a good idea to have a bisect_mode() function. >>> I don't like very much to blindly call some code when we might not need it. >>> >> > Mmmm. > > Actually, there is a neater way to do this. > > I'll such use the existence of BISECT_HEAD to inform the > implementation of bisect_mode(). > > This avoids the need for a separate .git/BISECT_MODE file.
Yeah, but then you have to be careful of the fact that BISECT_HEAD might have not been properly deleted or might have been created by the user for other purposes.
Thanks, Christian.