git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v13 5/8] bisect: introduce --no-checkout support into porcelain.

From
Jon Seymour <jon.seymour@gmail.com>
Date
Aug 3, 2011, 15:13 UTC
Message-ID
<CAH3Anro1Hs5VBT9901PoDdhGjtzTEZHWd9hgHvjfB_ivSErHMw@mail.gmail.com>
In-Reply-To
<CAP8UFD3QvXv_gnAtw3qMCOdDyAUAFMYcf33ieP+HebvTf3SGAg@mail.gmail.com>

On Thu, Aug 4, 2011 at 12:09 AM, Christian Couder <christian.couder@gmail.com> wrote:

Show 27 quoted lines
> On Wed, Aug 3, 2011 at 3:24 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
>> On Wed, Aug 3, 2011 at 10:46 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
>>> On Wed, Aug 3, 2011 at 3:27 PM, Christian Couder
>>> <chriscool@tuxfamily.org> wrote:
>>>> On Tuesday 02 August 2011 16:41:13 Jon Seymour wrote:
>>>>> On Tue, Aug 2, 2011 at 10:04 PM, Christian Couder
>>>>>
>>>>> If I was to do this, I'd prefer to change uses of $BISECT_MODE with a
>>>>> call to a function bisect_mode() that does the same thing.
>>>>
>>>> Yeah, I think it would be a good idea to have a bisect_mode() function.
>>>> I don't like very much to blindly call some code when we might not need it.
>>>>
>>>
>> Mmmm.
>>
>> Actually, there is a neater way to do this.
>>
>> I'll such use the existence of BISECT_HEAD to inform the
>> implementation of bisect_mode().
>>
>> This avoids the need for a separate .git/BISECT_MODE file.
>
> Yeah, but then you have to be careful of the fact that BISECT_HEAD
> might have not been properly deleted or might have been created by the
> user for other purposes.
>
I have removed $GIT_DIR/BISECT_MODE in v15.

If BISECT_HEAD was being used for other purposes, it is going to get deleted anyway, irrespective of whether we have a separate BISECT_MODE file, so I am not sure we need to consider that when deciding when we need a separate BISECT_MODE file.

FWIW: bisect_mode() was only going to get called from one place so I
just inlined the implementation in that place. (on the call to
bisect--helper).
jon.
Previous: Christian CouderNext: Christian Couder
Message 19 of 23 in “bisect: Add support for --no-checkout option”
  1. 0/8 bisect: Add support for --no-checkout optionJon Seymour, Aug 2, 2011
  2. 1/8 bisect: move argument parsing before state modification.Jon Seymour, Aug 2, 2011
  3. 2/8 bisect: use && to connect statements that are deferred with eval.Jon Seymour, Aug 2, 2011
  4. 3/8 bisect: add tests to document expected behaviour in presence of broken trees.Jon Seymour, Aug 2, 2011
  5. 4/8 bisect: introduce support for --no-checkout option.Jon Seymour, Aug 2, 2011
  6. Christian CouderAug 2, 2011
  7. Jon SeymourAug 2, 2011
  8. Junio C HamanoAug 2, 2011
  9. Jon SeymourAug 2, 2011
  10. Junio C HamanoAug 2, 2011
  11. Jon SeymourAug 2, 2011
  12. 5/8 bisect: introduce --no-checkout support into porcelain.Jon Seymour, Aug 2, 2011
  13. Christian CouderAug 2, 2011
  14. Jon SeymourAug 2, 2011
  15. Christian CouderAug 3, 2011
  16. Jon SeymourAug 3, 2011
  17. Jon SeymourAug 3, 2011
  18. Christian CouderAug 3, 2011
  19. Jon SeymourAug 3, 2011
  20. Christian CouderAug 3, 2011
  21. 6/8 bisect: add tests for the --no-checkout option.Jon Seymour, Aug 2, 2011
  22. 7/8 bisect: add documentation for --no-checkout option.Jon Seymour, Aug 2, 2011
  23. 8/8 bisect: change bisect function to update BISECT_HEAD, rather than HEAD.Jon Seymour, Aug 2, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.