git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v13 5/8] bisect: introduce --no-checkout support into porcelain.

From
Jon Seymour <jon.seymour@gmail.com>
Date
Aug 2, 2011, 14:41 UTC
Message-ID
<CAH3AnrrkAeN3BgnnFBsbzh=37tC6f6aRACgk94wxW85qFQpfVw@mail.gmail.com>
In-Reply-To
<CAP8UFD3XzUjxiz6QQzyTOYzfiWrF4ckiv0h+gvi7YuZkma6yiw@mail.gmail.com>

On Tue, Aug 2, 2011 at 10:04 PM, Christian Couder <christian.couder@gmail.com> wrote:

Show 10 quoted lines
> On Tue, Aug 2, 2011 at 1:29 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
>> @@ -34,6 +34,8 @@ require_work_tree
>>  _x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'
>>  _x40="$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40"
>>
>> +BISECT_MODE=$(test -f "$GIT_DIR/BISECT_MODE" && cat "$GIT_DIR/BISECT_MODE")
>
> Could you put this line just where it is needed, that is in
> bisect_next() and bisect_reset()?
>

Ultimately, it is also needed in paths that call bisect_state(), such as bisect_run() and bisect_skip() so I am not keen to do this.

If I was to do this, I'd prefer to change uses of $BISECT_MODE with a call to a function bisect_mode() that does the same thing.

jon.
Previous: Christian CouderNext: Christian Couder
Message 14 of 23 in “bisect: Add support for --no-checkout option”
  1. 0/8 bisect: Add support for --no-checkout optionJon Seymour, Aug 2, 2011
  2. 1/8 bisect: move argument parsing before state modification.Jon Seymour, Aug 2, 2011
  3. 2/8 bisect: use && to connect statements that are deferred with eval.Jon Seymour, Aug 2, 2011
  4. 3/8 bisect: add tests to document expected behaviour in presence of broken trees.Jon Seymour, Aug 2, 2011
  5. 4/8 bisect: introduce support for --no-checkout option.Jon Seymour, Aug 2, 2011
  6. Christian CouderAug 2, 2011
  7. Jon SeymourAug 2, 2011
  8. Junio C HamanoAug 2, 2011
  9. Jon SeymourAug 2, 2011
  10. Junio C HamanoAug 2, 2011
  11. Jon SeymourAug 2, 2011
  12. 5/8 bisect: introduce --no-checkout support into porcelain.Jon Seymour, Aug 2, 2011
  13. Christian CouderAug 2, 2011
  14. Jon SeymourAug 2, 2011
  15. Christian CouderAug 3, 2011
  16. Jon SeymourAug 3, 2011
  17. Jon SeymourAug 3, 2011
  18. Christian CouderAug 3, 2011
  19. Jon SeymourAug 3, 2011
  20. Christian CouderAug 3, 2011
  21. 6/8 bisect: add tests for the --no-checkout option.Jon Seymour, Aug 2, 2011
  22. 7/8 bisect: add documentation for --no-checkout option.Jon Seymour, Aug 2, 2011
  23. 8/8 bisect: change bisect function to update BISECT_HEAD, rather than HEAD.Jon Seymour, Aug 2, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.