git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] promisor-remote: fix segfault when remote URL is missing

From
Christian Couder <christian.couder@gmail.com>
Date
Mar 12, 2025, 11:48 UTC
Message-ID
<CAP8UFD1v7+AO7BJRN2VomM8e8FRbUZF=eP=nvvrdh6VzTwJpNA@mail.gmail.com>
In-Reply-To
<xmqqikof4i60.fsf@gitster.g>
On Tue, Mar 11, 2025 at 5:59 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Christian Couder <christian.couder@gmail.com> writes:
Show 11 quoted lines
> > We could have modified strvec_push() to behave like
> > strvec_push_nodup() and accept `NULL`, but it's not clear that it's
> > the right thing to do for the strvec API. 'strvec' is a kind of NULL
> > terminated array that is designed to be compatible with 'argv'
> > variables used on the command line. So we might want to disallow
> > pushing any `NULL` in it instead.
> >
> > It's also not clear if `xstrdup(NULL)` should crash or BUG or just
> > return NULL.
>
> Yup, the above two paragraphs are irrelevant, I would think.
I have removed them.
Thanks.
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 35 in “promisor-remote: fix segfault when remote URL is missing”
  1. promisor-remote: fix segfault when remote URL is missingChristian Couder, Mar 10, 2025
  2. Junio C HamanoMar 10, 2025
  3. Christian CouderMar 11, 2025
  4. Junio C HamanoMar 11, 2025
  5. promisor-remote: fix segfault when remote URL is missingChristian Couder, Mar 11, 2025
  6. Junio C HamanoMar 11, 2025
  7. Christian CouderMar 12, 2025
  8. Junio C HamanoMar 11, 2025
  9. Christian CouderMar 12, 2025
  10. Jeff KingMar 11, 2025
  11. Junio C HamanoMar 11, 2025
  12. Christian CouderMar 12, 2025
  13. promisor-remote: fix segfault when remote URL is missingChristian Couder, Mar 12, 2025
  14. Junio C HamanoMar 12, 2025
  15. Christian CouderMar 13, 2025
  16. Junio C HamanoMar 13, 2025
  17. Christian CouderMar 14, 2025
  18. Junio C HamanoMar 14, 2025
  19. promisor-remote: fix segfault when remote URL is missingChristian Couder, Mar 13, 2025
  20. Junio C HamanoMar 13, 2025
  21. Junio C HamanoMar 13, 2025
  22. Christian CouderMar 14, 2025
  23. 0/3 "promisor-remote" capability fixesChristian Couder, Mar 14, 2025
  24. 1/3 promisor-remote: fix segfault when remote URL is missingChristian Couder, Mar 14, 2025
  25. Junio C HamanoMar 14, 2025
  26. Christian CouderMar 18, 2025
  27. 2/3 promisor-remote: fix possible issue when no URL is advertisedChristian Couder, Mar 14, 2025
  28. 3/3 promisor-remote: compare remote names case sensitivelyChristian Couder, Mar 14, 2025
  29. Junio C HamanoMar 14, 2025
  30. Christian CouderMar 18, 2025
  31. 0/4 "promisor-remote" capability fixesChristian Couder, Mar 18, 2025
  32. 1/4 t5710: arrange to delete the client before cloningChristian Couder, Mar 18, 2025
  33. 2/4 promisor-remote: fix segfault when remote URL is missingChristian Couder, Mar 18, 2025
  34. 3/4 promisor-remote: fix possible issue when no URL is advertisedChristian Couder, Mar 18, 2025
  35. 4/4 promisor-remote: compare remote names case sensitivelyChristian Couder, Mar 18, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.