From: Christian Couder <christian.couder@gmail.com>
Date: Wed, 12 Mar 2025 11:48:34 GMT
Subject: Re: [PATCH v2] promisor-remote: fix segfault when remote URL is missing
Message-ID: <CAP8UFD1v7+AO7BJRN2VomM8e8FRbUZF=eP=nvvrdh6VzTwJpNA@mail.gmail.com>
In-Reply-To: <xmqqikof4i60.fsf@gitster.g>

On Tue, Mar 11, 2025 at 5:59 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Christian Couder <christian.couder@gmail.com> writes:

> > We could have modified strvec_push() to behave like
> > strvec_push_nodup() and accept `NULL`, but it's not clear that it's
> > the right thing to do for the strvec API. 'strvec' is a kind of NULL
> > terminated array that is designed to be compatible with 'argv'
> > variables used on the command line. So we might want to disallow
> > pushing any `NULL` in it instead.
> >
> > It's also not clear if `xstrdup(NULL)` should crash or BUG or just
> > return NULL.
>
> Yup, the above two paragraphs are irrelevant, I would think.

I have removed them.

Thanks.