Re: [PATCH v5 1/3] promisor-remote: fix segfault when remote URL is missing

> > +test_expect_success "clone with 'KnownName' and missing URL in the config" '
> > +     git -C server config promisor.advertise true &&
> > +
> > +     # Clone from server to create a client
> > +     # Lazy fetching by the client from the LOP will fail because of the
> > +     # missing URL in the client config, so the server will have to lazy
> > +     # fetch from the LOP.
> > +     GIT_NO_LAZY_FETCH=0 git clone -c remote.lop.promisor=true \
> > +             -c promisor.acceptfromserver=KnownName \
> > +             --no-local --filter="blob:limit=5k" server client &&
> > +     test_when_finished "rm -rf client" &&
>
> These are the other way around.  When 'clone' fails, test_when_finished
> is not run, so nobody arranges the new directory 'client' to be removed.
> "git clone" does try to remove in such a case, but we are protecting
> against a failing "clone", so swapping them around, i.e. arrange to
> remove it and then try to create it, would make more sense.

> > +test_expect_success "clone with 'KnownUrl' and url not configured on the server" '
> > +     git -C server config promisor.advertise true &&
> > +
> > +     git -C server config unset remote.lop.url &&
> > +     test_when_finished "git -C server config set remote.lop.url \"file://$(pwd)/lop\"" &&
>
> Probably the same principle applies here, but the case where "git
> config" fails, it is likely that the file is not touched at all, or
> it gets so corrupt beyond salvaging with another "config set", so it
> matters much less than the previous one.