Re: [PATCH 78/83] Move libified code from builtin/apply.c to apply.{c,h}

> On Wed, May 4, 2016 at 5:39 PM, Christian Couder
> <christian.couder@gmail.com> wrote:
>>
>> Right now I get:
>>
>>> git log --summary -M -C -B -1 20f1d27
>> commit 20f1d274609f5dde2eaaa279e7ee79fd5ef9c849
>> Author: Christian Couder <chriscool@tuxfamily.org>
>> Date:   Fri Apr 22 20:55:46 2016 +0200
>>
>>     Move libified code from builtin/apply.c to apply.{c,h}
>>
>>     Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>>
>>  copy builtin/apply.c => apply.c (96%)
>>  rewrite builtin/apply.c (96%)
>
> Ah.. I forgot about -B to break rename pairs! This looks good. I
> really need to go back to diff rename hints series, so we can annotate
> this commit and don't have to use -B every time.
>
>> And using format-patch:
>>
>>> git format-patch -M -C -B -1  -o ../../patches/test-libify-apply-use-in-am/ 20f1d27
>> ../../patches/test-libify-apply-use-in-am/0001-Move-libified-code-from-builtin-apply.c-to-apply.-c-.patch
>>> wc ../../patches/test-libify-apply-use-in-am/0001-Move-libified-code-from-builtin-apply.c-to-apply.-c-.patch
>>   5264  23426 147133
>
> It's a lot of lines, but if you look at diff stat, it's 244 insertions
> and 4906 deletions. I _think_ deletions are something reviewers don't
> have to pay much attention to (trusting that git moves code
> correctly), so only 244 lines to review are really nice. But I may be
> wrong.