Re: [PATCH 00/83] libify apply and use lib in am

From: Duy Nguyen <pclouds@gmail.com>
Date: Apr 25, 2016, 10:11 UTC
Message-ID: <CACsJy8DfcEeOwoN0e401gwuBG-HskY7-k1RYb58+vrEjm8P5CQ@mail.gmail.com>
In-Reply-To: <CAP8UFD05Cpsms8Tf_VmMeemoerfMm0E8fUqL3o0n_9d1hu7VMg@mail.gmail.com>

On Mon, Apr 25, 2016 at 4:57 PM, Christian Couder <christian.couder@gmail.com> wrote:

Show 10 quoted lines

>> But why write so many times when nobody reads it? We only need to
>> write before git-apply exits,
>
> You mean `git am` here I think.
>
>> either after successfully applying the
>> whole series, or after it stops at conflicts, and maybe even at die()
>> and SIGINT. Yes if git-apply segfaults,
>
> Here too.

Yep it's git-am. I didn't read the series, I simply ran and misread the traces a bit.

Show 7 quoted lines

>> then the index update is lost,
>> but in such a case, it's usually a good idea to restart fresh anyway.
>> When you only write index once (or twice) it won't matter if
>> split-index is used.
>
> Yeah I agree, but it would need further work, that can be done after
> this series is merged.

Sure.

> And I am not sure if the potential gains on a typical rebase would be worth it.

I didn't point it out, but in pathological cases where your patch series touches a lot of (or even every) files in the worktree, the gain from split-index lowers and could even disappear. I don't know how often that can happen in real life though.

Also, if you start to use split-index often, please note that I haven't addressed the sharedindex.* pruning part (it's labeled "experimental" for a reason), you may have to un-split the index and rm $GIT_DIR/sharedindex.* manually from time to time to keep disk usage down.

-- 
Duy