Re: [PATCH 09/83] builtin/apply: move 'check' global into 'struct apply_state'

From: Stefan Beller <sbeller@google.com>
Date: Apr 26, 2016, 16:31 UTC
Message-ID: <CAGZ79kauQU6B2EUcHyWck+ZP4G2OUAKrCkW3-PfsNZdijyF-TA@mail.gmail.com>
In-Reply-To: <CAP8UFD2rD5qo7TBPFdP5BifOGuWHAtZA2BNGDqnY_feoCfmKeQ@mail.gmail.com>

On Tue, Apr 26, 2016 at 9:26 AM, Christian Couder <christian.couder@gmail.com> wrote:

Show 12 quoted lines

>>
>>>  /*
>>> - *  --check turns on checking that the working tree matches the
>>> - *    files that are being modified, but doesn't apply the patch
>>
>> Oh I see it was moved from here. Not sure if we want to rename
>> comments along the way or just keep it in this series.
>
> I kept the existing comments when they were still relevant.
> It could be a cleanup to change them to something like what you
> suggest, but as it is not important for this series which is already
> long, I prefer to leave it for now.

Yeah that was my conclusion as well after some thought.

Thanks, Stefan