git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] prompt: do not double-discriminate detached HEAD

From
Eduardo R. D'Avila <erdavila@gmail.com>
Date
Jul 8, 2013, 01:12 UTC
Message-ID
<CAOz-D1+DU=DziVOcoa1=vy-pt8AX8wnUPY38tksep4S7ngKLpA@mail.gmail.com>
In-Reply-To
<1373201565-14030-1-git-send-email-artagnon@gmail.com>

I think color in terminals should be used to highlight and make it easier to see textual information, not to replace them. So I would keep the parenthesis.

> +                               test -n "${GIT_PS1_SHOWCOLORHINTS-}" || b="($b)"

Also, the proposed change has a side-effect because color is not possible in non-pc mode, even if GIT_PS1_SHOWCOLORHINTS is defined. (Non-pc mode with GIT_PS1_SHOWCOLORHINTS defined would make the detached HEAD not be shown neither in red nor within parenthesis).

Regards,
Eduardo R. D'Avila
Previous: Ramkumar Ramachandra
Message 6 of 6 in “prompt: do not double-discriminate detached HEAD”
  1. prompt: do not double-discriminate detached HEADRamkumar Ramachandra, Jul 7, 2013
  2. John SzakmeisterJul 7, 2013
  3. Junio C HamanoJul 7, 2013
  4. Kyle McKayJul 7, 2013
  5. Ramkumar RamachandraJul 8, 2013
  6. Eduardo R. D'AvilaJul 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.