git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] prompt: do not double-discriminate detached HEAD

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 7, 2013, 17:53 UTC
Message-ID
<7vppuu45q8.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAEBDL5UfHpR3GNeqbDf9X3Ya+Spcpx0Byq5MZPMMsE=a3y2jhg@mail.gmail.com>
John Szakmeister <john@szakmeister.net> writes:
Show 12 quoted lines
> On Sun, Jul 7, 2013 at 8:52 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
>> When GIT_PS1_SHOWCOLORHINTS is turned on, there is no need to put a
>> detached HEAD within parenthesis: the color can be used to discriminate
>> the detached HEAD.
>>
>> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
>> ---
>>  For cuteness :)
>
> Personally, I'd rather see the parens kept.  Not everyone sees red
> very well--I know several people who can't see it at all, and it keeps
> it consistent with non-colored output.

+1; I find red on many terminal emulators to be too dark to tell, especially in a small font, from black myself.

Previous: John SzakmeisterNext: Kyle McKay
Message 3 of 6 in “prompt: do not double-discriminate detached HEAD”
  1. prompt: do not double-discriminate detached HEADRamkumar Ramachandra, Jul 7, 2013
  2. John SzakmeisterJul 7, 2013
  3. Junio C HamanoJul 7, 2013
  4. Kyle McKayJul 7, 2013
  5. Ramkumar RamachandraJul 8, 2013
  6. Eduardo R. D'AvilaJul 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.