From: Eduardo R. D'Avila <erdavila@gmail.com>
Date: Mon, 08 Jul 2013 01:12:50 GMT
Subject: Re: [PATCH] prompt: do not double-discriminate detached HEAD
Message-ID: <CAOz-D1+DU=DziVOcoa1=vy-pt8AX8wnUPY38tksep4S7ngKLpA@mail.gmail.com>
In-Reply-To: <1373201565-14030-1-git-send-email-artagnon@gmail.com>

I think color in terminals should be used to highlight and make it easier to see
textual information, not to replace them. So I would keep the parenthesis.

> +                               test -n "${GIT_PS1_SHOWCOLORHINTS-}" || b="($b)"

Also, the proposed change has a side-effect because color is not possible in
non-pc mode, even if GIT_PS1_SHOWCOLORHINTS is defined. (Non-pc mode
with GIT_PS1_SHOWCOLORHINTS defined would make the detached HEAD not be
shown neither in red nor within parenthesis).

Regards,

Eduardo R. D'Avila