Re: [PATCH] prompt: do not double-discriminate detached HEAD
On Jul 7, 2013, at 10:53, Junio C Hamano wrote:
Show 20 quoted lines
> John Szakmeister <john@szakmeister.net> writes:
>
>> On Sun, Jul 7, 2013 at 8:52 AM, Ramkumar Ramachandra <artagnon@gmail.com
>> > wrote:
>>> When GIT_PS1_SHOWCOLORHINTS is turned on, there is no need to put a
>>> detached HEAD within parenthesis: the color can be used to
>>> discriminate
>>> the detached HEAD.
>>>
>>> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
>>> ---
>>> For cuteness :)
>>
>> Personally, I'd rather see the parens kept. Not everyone sees red
>> very well--I know several people who can't see it at all, and it
>> keeps
>> it consistent with non-colored output.
>
> +1; I find red on many terminal emulators to be too dark to tell,
> especially in a small font, from black myself.
+1; me too for the same reason.