Re: [PATCH] prompt: do not double-discriminate detached HEAD
- From
John Szakmeister <john@szakmeister.net>
- Date
- Jul 7, 2013, 13:35 UTC
- Message-ID
- <CAEBDL5UfHpR3GNeqbDf9X3Ya+Spcpx0Byq5MZPMMsE=a3y2jhg@mail.gmail.com>
- In-Reply-To
- <1373201565-14030-1-git-send-email-artagnon@gmail.com>
On Sun, Jul 7, 2013 at 8:52 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
Show 7 quoted lines
> When GIT_PS1_SHOWCOLORHINTS is turned on, there is no need to put a > detached HEAD within parenthesis: the color can be used to discriminate > the detached HEAD. > > Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> > --- > For cuteness :)
Personally, I'd rather see the parens kept. Not everyone sees red very well--I know several people who can't see it at all, and it keeps it consistent with non-colored output.
-John