Re: [PATCH v2] advice: add stashBeforeCheckout advice for dirty branch switches

> Subject: Re: [GSOC] advice: add stashBeforeCheckout advice for dirty
> branch switches
>
> Patrick Steinhardt <ps@pks.im> writes:
>
>> It is used in "add.c", but not magically so. The function that you have
>> introduced is the only site that uses the new advice, but the function
>> is never called as far as I can see. So ultimately, the proposed change
>> does not have any effect on the user-observable behaviour.
>
> Thank you for the correction and for the bottom-posting reminder.
>
> You are right. The function advise_on_checkout_dirty_files() is defined
> but never called anywhere, so the patch has no user-observable effect.
> I also looked into the existing behaviour more carefully and found that
> unpack-trees.c already handles this case and prints a message telling
> the user to commit or stash their changes before switching branches.
>
> So the patch as written is both incomplete and duplicates existing
> behaviour. I will rework it in v3 to instead enhance the existing
> message in unpack-trees.c to also mention 'git checkout -m' for users
> who want to carry their local changes over to the new branch.
>