Re: [PATCH v6] unpack-trees: suggesting 'git checkout -m' with its repercussions
- From
Arsh Srivastava <arshsrivastava00@gmail.com>
- Date
- Mar 12, 2026, 19:03 UTC
- Message-ID
- <CAOAgETOd7-vPpBK+8rhE-i_vpqw48gDBdc3QPm3xWOR4w3c7jw@mail.gmail.com>
- In-Reply-To
- <xmqqwlzgev16.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> write:
> I wonder where this came from, as it is quite unusual to have a rephrased summary of what you respond to. > Is this LLM-generated summary that was copied-and-pasted without much human brain effort? > What is more usual is to quote the message you are responding to.
Actually as suspicious as it looks the mail was written by me only and I thought that each line was as important as other and I wanted to reply to each point you mentioned Sorry for shortening your response next time I will make sure that I will make quotations direct.
On Fri, 13 Mar 2026 at 00:26, Junio C Hamano <gitster@pobox.com> wrote:
Show 28 quoted lines
> > Arsh Srivastava <arshsrivastava00@gmail.com> writes: > > > Junio C Hamano <gitster@pobox.com> writes : > >> The commit message should focus on the "why" and "what" from a user perspective, following the project's standard format (problem description, then solution). > >> Also showed an example for the same. > >> Also, note that "extention" is a typo; it should be "extension". > >> Having said that, I am not sure if we want to suggest "checkout -m" in this situation after all. > >> Pointed out the difference between "stash" and "checkout -m". > >> When advice requires a multi-line warning about potential data loss. > >> The goal of these messages should be to provide a clear, safe next step, not a list of advanced alternatives with caveats. > >> After all, the users who need such an "it failed, now what should I do to recover?" message the most are relatively inexperienced users and we do not want the advice to be overwhelming. > >> Suggesting this "one-shot" approach to a user who is already in a state of friction (and likely less experienced) might be providing them with a "foot-gun" rather than a helpful tip. Generally, advice that nudges users toward the safest "golden paths" like stashing or committing is preferred. > >> For a microproject, you've successfully demonstrated that you can modify the advice system and update the test suite. > >> it might be better to drop the 'checkout -m' suggestion and instead focus on making the existing 'stash' and 'commit' advice as clear and helpful as possible. > > I wonder where this came from, as it is quite unusual to have a > rephrased summary of what you respond to. Is this LLM-generated > summary that was copied-and-pasted without much human brain effort? > > What is more usual is to quote the message you are responding to, > trim the parts you are not going to comment on and not necessary for > bystanders to read in order to understand your response, and then > sprinkle your comments in between the parts of the quoted message, > instead of saying only your thing before the message you are > responding to without trimming (which is highly frowned upon, and > people often tell you not to "top-post"). >