Re: [PATCH v2] advice: add stashBeforeCheckout advice for dirty branch switches

From: Karthik Nayak <karthik.188@gmail.com>
Date: Mar 10, 2026, 17:09 UTC
Message-ID: <CAOLa=ZQu1hyiwMpBxJ=0PhNCf6LQqBt3F3=kycDv9cZST_JTNw@mail.gmail.com>
In-Reply-To: <xmqqeclrwrz4.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 19 quoted lines

> Arsh Srivastava <arshsrivastava00@gmail.com> writes:
>
>> Subject: Re: [GSOC] advice: add stashBeforeCheckout advice for dirty
>> branch switches
>>
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>> Doesn't 'ADVICE_COMMIT_BEFORE_MERGE' already do this?
>>> So won't this simply be duplicating the same message?
>>
>> Thank you for the detailed review. You are correct, the existing message
>> ...
>> I will rework the patch in that direction and send a v4.
>>
>> Signed-off-by: Arsh Srivastava <arshsrivastava00@gmail.com>
>
> Just a comment by a bystander, but it confuses me quite a lot to see
> in-body "Subject:" and "Sign-off" in a message that is *not* a patch
> at all.  What are you signing off with this signature?

Tangentially, I know that b4 adds a "Sign-off" to the cover message.