git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 17:17 UTC

[PATCH 3/5] repo: remove unnecessary variable shadow

From
K Jayatheerth via GitGitGadget <gitgitgadget@gmail.com>
Date
Mar 10, 2026, 08:51 UTC
Message-ID
<185356a454ce8074ee8be5ebfee9e9086ab88b7b.1773132678.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.2233.git.git.1773132678.gitgitgadget@gmail.com>
From: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>

Avoid redeclaring `entry` inside the conditional block, removing unnecessary variable shadowing and improving code clarity without changing behavior.

Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
Acked-by: Justin Tobler <jltobler@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/repo.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/builtin/repo.c b/builtin/repo.c
index f943be7451..fae1141cff 100644
--- a/builtin/repo.c
+++ b/builtin/repo.c
@@ -445,7 +445,6 @@ static void stats_table_print_structure(const struct stats_table *table)
 		const char *unit = "";
 
 		if (entry) {
-			struct stats_table_entry *entry = item->util;
 			value = entry->value;
 			if (entry->unit)
 				unit = entry->unit;
-- 
gitgitgadget
Previous: LorenzoPegorari via GitGitGadgetNext: Junio C Hamano via GitGitGadget
Message 4 of 62 in “Advice on checkout dirty files”
  1. 0/5 Advice on checkout dirty filesArsh Srivastava via GitGitGadget, Mar 10, 2026
  2. 1/5 diff: handle ANSI escape codes in prefix when calculating diffstat widthLorenzoPegorari via GitGitGadget, Mar 10, 2026
  3. 2/5 t4052: test for diffstat width when prefix contains ANSI escape codesLorenzoPegorari via GitGitGadget, Mar 10, 2026
  4. 3/5 repo: remove unnecessary variable shadowK Jayatheerth via GitGitGadget, Mar 10, 2026
  5. 4/5 The 13th batchJunio C Hamano via GitGitGadget, Mar 10, 2026
  6. 5/5 advice: add stashBeforeCheckout advice for dirty branch switchesArsh Srivastava via GitGitGadget, Mar 10, 2026
  7. Phillip WoodMar 10, 2026
  8. Arsh SrivastavaMar 10, 2026
  9. Arsh SrivastavaMar 10, 2026
  10. advice: add stashBeforeCheckout advice for dirty branch switchesArsh Srivastava via GitGitGadget, Mar 10, 2026
  11. Arsh SrivastavaMar 10, 2026
  12. Patrick SteinhardtMar 10, 2026
  13. 0/2 Advice on checkout dirty filesArsh Srivastava via GitGitGadget, Mar 10, 2026
  14. 1/2 advice: add stashBeforeCheckout advice for dirty branch switchesArsh Srivastava via GitGitGadget, Mar 10, 2026
  15. 2/2 advice: add stashBeforeCheckout advice for dirty branch switches [GSOC]Arsh Srivastava via GitGitGadget, Mar 10, 2026
  16. Junio C HamanoMar 10, 2026
  17. Arsh SrivastavaMar 10, 2026
  18. Arsh SrivastavaMar 10, 2026
  19. Arsh SrivastavaMar 10, 2026
  20. Patrick SteinhardtMar 10, 2026
  21. Karthik NayakMar 10, 2026
  22. Arsh SrivastavaMar 10, 2026
  23. Arsh SrivastavaMar 10, 2026
  24. Arsh SrivastavaMar 10, 2026
  25. Junio C HamanoMar 10, 2026
  26. Arsh SrivastavaMar 10, 2026
  27. Arsh SrivastavaMar 10, 2026
  28. Junio C HamanoMar 10, 2026
  29. Karthik NayakMar 10, 2026
  30. Karthik NayakMar 10, 2026
  31. Arsh SrivastavaMar 10, 2026
  32. Arsh SrivastavaMar 10, 2026
  33. 0/5 Advice on checkout dirty filesArsh Srivastava via GitGitGadget, Mar 11, 2026
  34. 1/5 advice: add stashBeforeCheckout advice for dirty branch switchesArsh Srivastava via GitGitGadget, Mar 11, 2026
  35. 2/5 advice: add stashBeforeCheckout advice for dirty branch switches [GSOC]Arsh Srivastava via GitGitGadget, Mar 11, 2026
  36. 3/5 unpack-trees: suggesting 'git checkout -m <branch>' with its repercussionsArsh Srivastava via GitGitGadget, Mar 11, 2026
  37. 4/5 Updating tests and unpack-tress.c [GSOC]Arsh Srivastava via GitGitGadget, Mar 11, 2026
  38. 5/5 File updation [GSOC]Arsh Srivastava via GitGitGadget, Mar 11, 2026
  39. Junio C HamanoMar 11, 2026
  40. Arsh SrivastavaMar 11, 2026
  41. 0/3 Advice on checkout dirty filesArsh Srivastava via GitGitGadget, Mar 11, 2026
  42. 1/3 advice: add stashBeforeCheckout advice for dirty branch switchesArsh Srivastava via GitGitGadget, Mar 11, 2026
  43. 2/3 advice: add stashBeforeCheckout advice for dirty branch switches [GSOC]Arsh Srivastava via GitGitGadget, Mar 11, 2026
  44. 3/3 unpack-trees: suggesting 'git checkout -m <branch>' with its repercussionsArsh Srivastava via GitGitGadget, Mar 11, 2026
  45. Junio C HamanoMar 12, 2026
  46. Arsh SrivastavaMar 12, 2026
  47. unpack-trees: suggesting 'git checkout -m' with its repercussionsArsh Srivastava via GitGitGadget, Mar 12, 2026
  48. Junio C HamanoMar 12, 2026
  49. Arsh SrivastavaMar 12, 2026
  50. Junio C HamanoMar 12, 2026
  51. Arsh SrivastavaMar 12, 2026
  52. Junio C HamanoMar 12, 2026
  53. Arsh SrivastavaMar 12, 2026
  54. unpack-trees: suggest using 'git stash' when checkout failsArsh Srivastava via GitGitGadget, Mar 12, 2026
  55. Junio C HamanoMar 12, 2026
  56. Arsh SrivastavaMar 13, 2026
  57. Karthik NayakMar 13, 2026
  58. Arsh SrivastavaMar 13, 2026
  59. Arsh SrivastavaMar 13, 2026
  60. Arsh SrivastavaMar 13, 2026
  61. Junio C HamanoMar 13, 2026
  62. Konstantin RyabitsevMar 14, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.