From: karthik nayak <karthik.188@gmail.com>
Date: Tue, 05 Nov 2024 11:20:19 GMT
Subject: Re: [PATCH 3/8] refs/reftable: read references via `struct reftable_backend`
Message-ID: <CAOLa=ZRO_F93DDZefForD4Jx-ReXDKBnHeL8yOkHwPNtJ6S_bQ@mail.gmail.com>
In-Reply-To: <00fdf392a64f2b0f2e9bb7b398565a87c2e187b5.1730732881.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Refactor `read_ref_without_reload()` to accept a `struct reftable_stack`

Do you mean `struct reftable_backend` here?

> as input instead of accepting a `struct reftable_stack`. This allows us
> to implement an additional caching layer when reading refs where we can
> reuse reftable iterators.
>

Nit: This commit also refactors the function to use the newly defined
'REFTABLE_HASH_*'. Maybe worth mentioning in the commit.

The patch itself looks good!

[snip]