Re: [PATCH v2 11/12] gc: automatically write commit-graph files

From: Martin Ågren <martin.agren@gmail.com>
Date: May 17, 2018, 18:20 UTC
Message-ID: <CAN0heSr+Aeu1By2LXxtmQN=Lq3RYwuHgYv36GjRN2Cfg73LA4Q@mail.gmail.com>
In-Reply-To: <20180511211504.79877-12-dstolee@microsoft.com>

On 11 May 2018 at 23:15, Derrick Stolee <dstolee@microsoft.com> wrote:

> The commit-graph file is a very helpful feature for speeding up git
> operations. In order to make it more useful, write the commit-graph file
> by default during standard garbage collection operations.

So does it really write by default...

> Add a 'gc.commitGraph' config setting that triggers writing a
> commit-graph file after any non-trivial 'git gc' command. Defaults to
> false while the commit-graph feature matures. We specifically do not

or not...? I guess the first paragraph has simply been there since before you changed your mind about the default?

> want to turn this on by default until the commit-graph feature is fully
> integrated with history-modifying features like shallow clones.

So if someone would turn this on with a shallow clone, ... Do we want some note (warning?) around that in the user documentation?

Martin