Re: [PATCH 1/2] transport-helper: report errors properly

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 13, 2013, 06:43 UTC
Message-ID: <CAMP44s3gOXvHknN1yXQcDYP=OBfjm7=eJnSkh5cj5QJNOarEWQ@mail.gmail.com>
In-Reply-To: <20130413060031.GA22374@sigill.intra.peff.net>

On Sat, Apr 13, 2013 at 1:00 AM, Jeff King <peff@peff.net> wrote:

Show 12 quoted lines

> On Sat, Apr 13, 2013 at 12:42:29AM -0500, Felipe Contreras wrote:
>
>> To me, the reality is obvious: my patch didn't require such a big
>> commit message, the short version was fine, the only reason Jeff King
>> insisted on a longer version is because the patch came from me.
>
> Get over yourself. The reason I suggested a longer commit message for
> your commit is because after spending several hours figuring out what
> the current code did, and what it should be doing instead, I wanted to
> document that effort so that I and other readers did not have to do it
> again later. I didn't even review the other patch you mention, so I
> could not possibly have come to the same point with it.

The double standard might not come from you, perhaps you subject all the patches you review to the same standard, it comes from the fact that the patches you review have an unfair disadvantage.

> But hey, if you want to have paranoid fantasies that I'm persecuting you
> (by writing the longer commit messages for you!), go ahead.

You don't persecute me, you persecute my patches. I could almost picture the moment you see a patch is coming from me, you have already decided to rewrite the commit message, even before reading it. Antoine is not me, so you simply didn't review that patch.

> If you don't want me to review your patches, that's fine by me, too; our
> discussions often end up frustrating, and it's clear we do not agree on
> very much with respect to process or design. But if you don't want that,
> please stop cc'ing me when you send out the patches.

This comment was directed towards Junio, I do hope he is able to see the double standard. As for you, I think your reviews have value, but I also think you dwelling in irrelevant details do slow things down, which is not too bad, what is bad is that you assume that your opinions are facts (e.g. the commit message need to be bigger), and get angry when somebody disagrees with them.

Cheers.

-- 
Felipe Contreras