Re: [PATCH 2/2] transport-helper: mention helper name when it dies
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Apr 10, 2013, 21:35 UTC
- Message-ID
- <CAGdFq_ju7d59jm+d+cmM2T8zR7WjLEVf=HDGa-3Uo3GLbnqh6w@mail.gmail.com>
- In-Reply-To
- <20130410212833.GA5909@sigill.intra.peff.net>
On Wed, Apr 10, 2013 at 2:28 PM, Jeff King <peff@peff.net> wrote:
> Now that's the kind of whole-hearted endorsement I strive for. :)
It's nothing wrong with your patch, the main problem is that there's not really a good place to point users at.
Show 7 quoted lines
> If you have better wording, I'm open to it. I do note that we don't > actually have a manpage for "git-remote-https", though we do for others. > Probably "man git-remote-helpers" is the most sensible thing to point > the user to. But I don't even think this is worthy of a big advice > message. It's a bug in the helper, it shouldn't really happen, and > giving the user a token they can use to report or google for the error > is probably good enough.
Yeah, exactly. man git-remote-helpers is more a place for developers to read how to implement a git-remote-helper, not so much a place for users to read what they are, and/or how to use them.
-- Cheers,
Sverre Rabbelier