Re: [PATCH v4] transport-helper: report errors properly
- From
Jeff King <peff@peff.net>
- Date
- Apr 8, 2013, 19:30 UTC
- Message-ID
- <20130408193043.GD7337@sigill.intra.peff.net>
- In-Reply-To
- <CAGdFq_h9o+oMriF52Bh2e60eJfLM7F9GTbwcSE1mD3Leyt76Yg@mail.gmail.com>
On Mon, Apr 08, 2013 at 11:20:15AM -0700, Sverre Rabbelier wrote:
Show 6 quoted lines
> On Mon, Apr 8, 2013 at 7:40 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > + die("Reading from remote helper failed");
>
> Does the user know what a remote helper is? Could we point them at
> some helpful docs in case they don't?That's a good point. I wonder if it would be enough to say:
fatal: Reading from helper git-remote-X failed
That might make it more clear what the helper's role is, and showing the command name gives the user a starting point for running "man".
-Peff