Re: [PATCH v4] transport-helper: report errors properly

From: rh <richard_hubbe11@lavabit.com>
Date: Apr 10, 2013, 23:13 UTC
Message-ID: <20130410161320.679b68ca07cd1fe32bb25c70@lavabit.com>
In-Reply-To: <1365432004-20132-1-git-send-email-felipe.contreras@gmail.com>

On Mon, 8 Apr 2013 09:40:04 -0500 Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 6 quoted lines

> If a push fails because the remote-helper died (with fast-export), the
> user won't see any error message. So let's add one.
> 
> At the same time lets add tests to ensure this error is reported, and
> while we are at it, check the error from fast-import
>

....

Show 8 quoted lines

> +++ b/transport-helper.c
> @@ -54,7 +54,7 @@ static int recvline_fh(FILE *helper, struct strbuf
> *buffer) if (strbuf_getline(buffer, helper, '\n') == EOF) {
>  		if (debug)
>  			fprintf(stderr, "Debug: Remote helper quit.
> \n");
> -		exit(128);
> +		die("Reading from remote helper failed");

Do I read this correctly? If I'm in debug mode the remote helper quit but if not in debug mode it failed? Debuggers never fail they only quit!

>  	}
>  
>  	if (debug)