Re: [PATCH 1/2] transport-helper: report errors properly

From: Jeff King <peff@peff.net>
Date: Apr 13, 2013, 06:00 UTC
Message-ID: <20130413060031.GA22374@sigill.intra.peff.net>
In-Reply-To: <CAMP44s1pZW6OJ2nkegKFQq6=npPSiD4dX_z37t63B9baaFW16w@mail.gmail.com>

On Sat, Apr 13, 2013 at 12:42:29AM -0500, Felipe Contreras wrote:

> To me, the reality is obvious: my patch didn't require such a big
> commit message, the short version was fine, the only reason Jeff King
> insisted on a longer version is because the patch came from me.

Get over yourself. The reason I suggested a longer commit message for your commit is because after spending several hours figuring out what the current code did, and what it should be doing instead, I wanted to document that effort so that I and other readers did not have to do it again later. I didn't even review the other patch you mention, so I could not possibly have come to the same point with it.

But hey, if you want to have paranoid fantasies that I'm persecuting you (by writing the longer commit messages for you!), go ahead.

If you don't want me to review your patches, that's fine by me, too; our discussions often end up frustrating, and it's clear we do not agree on very much with respect to process or design. But if you don't want that, please stop cc'ing me when you send out the patches.

-Peff