Re: [PATCH v7 p1 07/13] remote-testgit: remove irrelevant test

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Dec 4, 2012, 14:03 UTC
Message-ID: <CAMP44s3C=Q3VLc=5PS-oBBib6eiew3Ou4-ZBHL91NfuKusCdSw@mail.gmail.com>
In-Reply-To: <20121203231321.GA5098@padd.com>

On Mon, Dec 3, 2012 at 5:13 PM, Pete Wyckoff <pw@padd.com> wrote:

Show 21 quoted lines

>> --- a/t/t5801-remote-helpers.sh
>> +++ b/t/t5801-remote-helpers.sh
>> @@ -53,19 +53,6 @@ test_expect_success 'pushing to local repo' '
>>       compare_refs localclone HEAD server HEAD
>>  '
>>
>> -# Generally, skip this test.  It demonstrates a now-fixed race in
>> -# git-remote-testgit, but is too slow to leave in for general use.
>> -: test_expect_success 'racily pushing to local repo' '
>> -     test_when_finished "rm -rf server2 localclone2" &&
>> -     cp -R server server2 &&
>> -     git clone "testgit::${PWD}/server2" localclone2 &&
>> -     (cd localclone2 &&
>> -     echo content >>file &&
>> -     git commit -a -m three &&
>> -     GIT_REMOTE_TESTGIT_SLEEPY=2 git push) &&
>> -     compare_refs localclone2 HEAD server2 HEAD
>> -'
>> -
>
> Why does this cause problems?

It doesn't.

> If you're going to rip it out, please finish the job, and take
> out the other two hunks that are needed to trigger this test.  See
> 7fb8e16 (git-remote-testgit: fix race when spawning fast-import,
> 2012-04-22).

That commit has absolutely nothing to do with the new remote-testgit, the old remote-testgit is called now remote-testpy, and its test has this chunk still there.

For the new remote-testgit this is irrelevant.

-- 
Felipe Contreras