git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v7 p1 13/13] fast-export: fix comparison in tests

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 28, 2012, 22:11 UTC
Message-ID
<1354140669-23533-14-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1354140669-23533-1-git-send-email-felipe.contreras@gmail.com>

First the expected, then the actual, otherwise the diff would be the opposite of what we want.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t9350-fast-export.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh
index 5948b65..1f59862 100755
--- a/t/t9350-fast-export.sh
+++ b/t/t9350-fast-export.sh
@@ -303,7 +303,7 @@ test_expect_success 'dropping tag of filtered out object' '
 (
 	cd limit-by-paths &&
 	git fast-export --tag-of-filtered-object=drop mytag -- there > output &&
-	test_cmp output expected
+	test_cmp expected output
 )
 '
 
@@ -320,7 +320,7 @@ test_expect_success 'rewriting tag of filtered out object' '
 (
 	cd limit-by-paths &&
 	git fast-export --tag-of-filtered-object=rewrite mytag -- there > output &&
-	test_cmp output expected
+	test_cmp expected output
 )
 '
 
@@ -351,7 +351,7 @@ test_expect_failure 'no exact-ref revisions included' '
 	(
 		cd limit-by-paths &&
 		git fast-export master~2..master~1 > output &&
-		test_cmp output expected
+		test_cmp expected output
 	)
 '
 
-- 
1.8.0.1
Previous: Felipe Contreras
Message 16 of 16 in “fast-export and remote-testgit improvements”
  1. 00/13 fast-export and remote-testgit improvementsFelipe Contreras, Nov 28, 2012
  2. 01/13 fast-export: avoid importing blob marksFelipe Contreras, Nov 28, 2012
  3. 02/13 remote-testgit: fix direction of marksFelipe Contreras, Nov 28, 2012
  4. 03/13 remote-helpers: fix failure messageFelipe Contreras, Nov 28, 2012
  5. 04/13 Rename git-remote-testgit to git-remote-testpyFelipe Contreras, Nov 28, 2012
  6. 05/13 Add new simplified git-remote-testgitFelipe Contreras, Nov 28, 2012
  7. 06/13 remote-testgit: remove non-local functionalityFelipe Contreras, Nov 28, 2012
  8. 07/13 remote-testgit: remove irrelevant testFelipe Contreras, Nov 28, 2012
  9. Pete WyckoffDec 3, 2012
  10. Felipe ContrerasDec 4, 2012
  11. 08/13 remote-testgit: cleanup testsFelipe Contreras, Nov 28, 2012
  12. 09/13 remote-testgit: exercise more featuresFelipe Contreras, Nov 28, 2012
  13. 10/13 remote-testgit: report success after an importFelipe Contreras, Nov 28, 2012
  14. 11/13 remote-testgit: implement the "done" feature manuallyFelipe Contreras, Nov 28, 2012
  15. 12/13 fast-export: trivial cleanupFelipe Contreras, Nov 28, 2012
  16. 13/13 fast-export: fix comparison in testsFelipe Contreras, Nov 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.