git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v7 p1 11/13] remote-testgit: implement the "done" feature manually

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 28, 2012, 22:11 UTC
Message-ID
<1354140669-23533-12-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1354140669-23533-1-git-send-email-felipe.contreras@gmail.com>

People who want to write their own remote-helper will find it more useful to see clearly how they are supposed to advertise and implement the "done" feature themselves.

Right now we are relying on fast-export to do that by using the --use-done-feature argument. However, people writing their own remote-helper would probably not have such an option, as they would probably be writing the fast-export functionality themselves.

It should now be clearer to them.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 git-remote-testgit | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/git-remote-testgit b/git-remote-testgit
index 6fb8780..b395c8d 100755
--- a/git-remote-testgit
+++ b/git-remote-testgit
@@ -61,8 +61,10 @@ do
 			echo "feature import-marks=$gitmarks"
 			echo "feature export-marks=$gitmarks"
 		fi
-		git fast-export --use-done-feature "${testgitmarks_args[@]}" $refs |
+		echo "feature done"
+		git fast-export "${testgitmarks_args[@]}" $refs |
 		sed -e "s#refs/heads/#${prefix}/heads/#g"
+		echo "done"
 		;;
 	export)
 		before=$(git for-each-ref --format='%(refname) %(objectname)')
-- 
1.8.0.1
Previous: Felipe ContrerasNext: Felipe Contreras
Message 14 of 16 in “fast-export and remote-testgit improvements”
  1. 00/13 fast-export and remote-testgit improvementsFelipe Contreras, Nov 28, 2012
  2. 01/13 fast-export: avoid importing blob marksFelipe Contreras, Nov 28, 2012
  3. 02/13 remote-testgit: fix direction of marksFelipe Contreras, Nov 28, 2012
  4. 03/13 remote-helpers: fix failure messageFelipe Contreras, Nov 28, 2012
  5. 04/13 Rename git-remote-testgit to git-remote-testpyFelipe Contreras, Nov 28, 2012
  6. 05/13 Add new simplified git-remote-testgitFelipe Contreras, Nov 28, 2012
  7. 06/13 remote-testgit: remove non-local functionalityFelipe Contreras, Nov 28, 2012
  8. 07/13 remote-testgit: remove irrelevant testFelipe Contreras, Nov 28, 2012
  9. Pete WyckoffDec 3, 2012
  10. Felipe ContrerasDec 4, 2012
  11. 08/13 remote-testgit: cleanup testsFelipe Contreras, Nov 28, 2012
  12. 09/13 remote-testgit: exercise more featuresFelipe Contreras, Nov 28, 2012
  13. 10/13 remote-testgit: report success after an importFelipe Contreras, Nov 28, 2012
  14. 11/13 remote-testgit: implement the "done" feature manuallyFelipe Contreras, Nov 28, 2012
  15. 12/13 fast-export: trivial cleanupFelipe Contreras, Nov 28, 2012
  16. 13/13 fast-export: fix comparison in testsFelipe Contreras, Nov 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.