git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v7 p1 12/13] fast-export: trivial cleanup

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 28, 2012, 22:11 UTC
Message-ID
<1354140669-23533-13-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1354140669-23533-1-git-send-email-felipe.contreras@gmail.com>

Setting 'commit' to 'commit' is a no-op. It might have been there to avoid a compiler warning, but if so, it was the compiler to blame, and it's certainly not there any more.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/fast-export.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/fast-export.c b/builtin/fast-export.c
index 9b70ec1..191936c 100644
--- a/builtin/fast-export.c
+++ b/builtin/fast-export.c
@@ -483,7 +483,7 @@ static void get_tags_and_duplicates(struct object_array *pending,
 	for (i = 0; i < pending->nr; i++) {
 		struct object_array_entry *e = pending->objects + i;
 		unsigned char sha1[20];
-		struct commit *commit = commit;
+		struct commit *commit;
 		char *full_name;
 
 		if (dwim_ref(e->name, strlen(e->name), sha1, &full_name) != 1)
-- 
1.8.0.1
Previous: Felipe ContrerasNext: Felipe Contreras
Message 15 of 16 in “fast-export and remote-testgit improvements”
  1. 00/13 fast-export and remote-testgit improvementsFelipe Contreras, Nov 28, 2012
  2. 01/13 fast-export: avoid importing blob marksFelipe Contreras, Nov 28, 2012
  3. 02/13 remote-testgit: fix direction of marksFelipe Contreras, Nov 28, 2012
  4. 03/13 remote-helpers: fix failure messageFelipe Contreras, Nov 28, 2012
  5. 04/13 Rename git-remote-testgit to git-remote-testpyFelipe Contreras, Nov 28, 2012
  6. 05/13 Add new simplified git-remote-testgitFelipe Contreras, Nov 28, 2012
  7. 06/13 remote-testgit: remove non-local functionalityFelipe Contreras, Nov 28, 2012
  8. 07/13 remote-testgit: remove irrelevant testFelipe Contreras, Nov 28, 2012
  9. Pete WyckoffDec 3, 2012
  10. Felipe ContrerasDec 4, 2012
  11. 08/13 remote-testgit: cleanup testsFelipe Contreras, Nov 28, 2012
  12. 09/13 remote-testgit: exercise more featuresFelipe Contreras, Nov 28, 2012
  13. 10/13 remote-testgit: report success after an importFelipe Contreras, Nov 28, 2012
  14. 11/13 remote-testgit: implement the "done" feature manuallyFelipe Contreras, Nov 28, 2012
  15. 12/13 fast-export: trivial cleanupFelipe Contreras, Nov 28, 2012
  16. 13/13 fast-export: fix comparison in testsFelipe Contreras, Nov 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.