git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v7 p1 08/13] remote-testgit: cleanup tests

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 28, 2012, 22:11 UTC
Message-ID
<1354140669-23533-9-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1354140669-23533-1-git-send-email-felipe.contreras@gmail.com>

We don't need a bare 'server' and an intermediary 'public'. The repos can talk to each other directly; that's what we want to exercise.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t5801-remote-helpers.sh | 63 ++++++++++++++++++++++-------------------------
 1 file changed, 29 insertions(+), 34 deletions(-)
diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
index 6801529..bc0b5f7 100755
--- a/t/t5801-remote-helpers.sh
+++ b/t/t5801-remote-helpers.sh
@@ -19,100 +19,95 @@ compare_refs() {
 }
 
 test_expect_success 'setup repository' '
-	git init --bare server/.git &&
-	git clone server public &&
-	(cd public &&
+	git init server &&
+	(cd server &&
 	 echo content >file &&
 	 git add file &&
-	 git commit -m one &&
-	 git push origin master)
+	 git commit -m one)
 '
 
 test_expect_success 'cloning from local repo' '
-	git clone "testgit::${PWD}/server" localclone &&
-	test_cmp public/file localclone/file
+	git clone "testgit::${PWD}/server" local &&
+	test_cmp server/file local/file
 '
 
 test_expect_success 'create new commit on remote' '
-	(cd public &&
+	(cd server &&
 	 echo content >>file &&
-	 git commit -a -m two &&
-	 git push)
+	 git commit -a -m two)
 '
 
 test_expect_success 'pulling from local repo' '
-	(cd localclone && git pull) &&
-	test_cmp public/file localclone/file
+	(cd local && git pull) &&
+	test_cmp server/file local/file
 '
 
 test_expect_success 'pushing to local repo' '
-	(cd localclone &&
+	(cd local &&
 	echo content >>file &&
 	git commit -a -m three &&
 	git push) &&
-	compare_refs localclone HEAD server HEAD
+	compare_refs local HEAD server HEAD
 '
 
 test_expect_success 'fetch new branch' '
-	(cd public &&
+	(cd server &&
+	 git reset --hard &&
 	 git checkout -b new &&
 	 echo content >>file &&
-	 git commit -a -m five &&
-	 git push origin new
+	 git commit -a -m five
 	) &&
-	(cd localclone &&
+	(cd local &&
 	 git fetch origin new
 	) &&
-	compare_refs public HEAD localclone FETCH_HEAD
+	compare_refs server HEAD local FETCH_HEAD
 '
 
 #
 # This is only needed because of a bug not detected by this script. It will be
 # fixed shortly, but for now lets not cause regressions.
 #
-test_expect_success 'bump commit in public' '
-	(cd public &&
+test_expect_success 'bump commit in server' '
+	(cd server &&
 	git checkout master &&
-	git pull &&
 	echo content >>file &&
-	git commit -a -m four &&
-	git push) &&
-	compare_refs public HEAD server HEAD
+	git commit -a -m four) &&
+	compare_refs server HEAD server HEAD
 '
 
 test_expect_success 'fetch multiple branches' '
-	(cd localclone &&
+	(cd local &&
 	 git fetch
 	) &&
-	compare_refs server master localclone refs/remotes/origin/master &&
-	compare_refs server new localclone refs/remotes/origin/new
+	compare_refs server master local refs/remotes/origin/master &&
+	compare_refs server new local refs/remotes/origin/new
 '
 
 test_expect_success 'push when remote has extra refs' '
-	(cd localclone &&
+	(cd local &&
 	 git reset --hard origin/master &&
 	 echo content >>file &&
 	 git commit -a -m six &&
 	 git push
 	) &&
-	compare_refs localclone master server master
+	compare_refs local master server master
 '
 
 test_expect_success 'push new branch by name' '
-	(cd localclone &&
+	(cd local &&
 	 git checkout -b new-name  &&
 	 echo content >>file &&
 	 git commit -a -m seven &&
 	 git push origin new-name
 	) &&
-	compare_refs localclone HEAD server refs/heads/new-name
+	compare_refs local HEAD server refs/heads/new-name
 '
 
 test_expect_failure 'push new branch with old:new refspec' '
-	(cd localclone &&
+	(cd local &&
 	 git push origin new-name:new-refspec
 	) &&
-	compare_refs localclone HEAD server refs/heads/new-refspec
+	compare_refs local HEAD server refs/heads/new-refspec
 '
 
 test_done
-- 
1.8.0.1
Previous: Felipe ContrerasNext: Felipe Contreras
Message 11 of 16 in “fast-export and remote-testgit improvements”
  1. 00/13 fast-export and remote-testgit improvementsFelipe Contreras, Nov 28, 2012
  2. 01/13 fast-export: avoid importing blob marksFelipe Contreras, Nov 28, 2012
  3. 02/13 remote-testgit: fix direction of marksFelipe Contreras, Nov 28, 2012
  4. 03/13 remote-helpers: fix failure messageFelipe Contreras, Nov 28, 2012
  5. 04/13 Rename git-remote-testgit to git-remote-testpyFelipe Contreras, Nov 28, 2012
  6. 05/13 Add new simplified git-remote-testgitFelipe Contreras, Nov 28, 2012
  7. 06/13 remote-testgit: remove non-local functionalityFelipe Contreras, Nov 28, 2012
  8. 07/13 remote-testgit: remove irrelevant testFelipe Contreras, Nov 28, 2012
  9. Pete WyckoffDec 3, 2012
  10. Felipe ContrerasDec 4, 2012
  11. 08/13 remote-testgit: cleanup testsFelipe Contreras, Nov 28, 2012
  12. 09/13 remote-testgit: exercise more featuresFelipe Contreras, Nov 28, 2012
  13. 10/13 remote-testgit: report success after an importFelipe Contreras, Nov 28, 2012
  14. 11/13 remote-testgit: implement the "done" feature manuallyFelipe Contreras, Nov 28, 2012
  15. 12/13 fast-export: trivial cleanupFelipe Contreras, Nov 28, 2012
  16. 13/13 fast-export: fix comparison in testsFelipe Contreras, Nov 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.