Re: [PATCH v3 1/4] completion: be nicer with zsh

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Feb 4, 2012, 15:46 UTC
Message-ID: <CAMP44s2QdJ4+qgg4fF5-DOWHx3Btd0pTivTT9s_E=qqxg16YLQ@mail.gmail.com>
In-Reply-To: <7vehuboe5g.fsf@alter.siamese.dyndns.org>

On Fri, Feb 3, 2012 at 10:28 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Fri, Feb 3, 2012 at 2:17 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> ...
>>> Here is what I ended up in preparation for queuing the series. I still
>>> haven't seen any version of 4/4, but please check $gmane/189683 and see if
>>> that matches what you intended. Also I am assuming $gmane/189606 relayed
>>> by Jonathan is a squash between your 2 and 3 (which didn't reach me), so
>>> please advise if that does not match what you want to have.
>>
>> This is getting ridiculous, now I sent the patches directly to you, is
>> your pobox.com server also silently dropping them for no reason?
>
> Do not blame pobox.com; they have nothing to do with the corruption of
> your headers.

No, but they have everything to do with *silently* dropping it. Why couldn't they _at least_ return an error saying that the headers are wrong? Note that other servers didn't even complain, they processed the mail happily.

In any case, the one to blame for the header corruption is git:

% git blame -e -L 947,+7 contrib/completion/git-completion.bash v1.7.9
eaa4e6ee (<jrnieder@gmail.com>   2009-11-17 18:49:10 -0600 947)
__git_compute_porcelain_commands ()
eaa4e6ee (<jrnieder@gmail.com>   2009-11-17 18:49:10 -0600 948) {
eaa4e6ee (<jrnieder@gmail.com>   2009-11-17 18:49:10 -0600 949)
 __git_compute_all_commands
eaa4e6ee (<jrnieder@gmail.com>   2009-11-17 18:49:10 -0600 950)
 : ${__git_porcelain_commands:=$(__git_list_porcelain_commands)}
eaa4e6ee (<jrnieder@gmail.com>   2009-11-17 18:49:10 -0600 951) }
f2bb9f88 (<spearce@spearce.org>> 2006-11-27 03:41:01 -0500 952)
c3898111 (<szeder@ira.uka.de>    2010-10-11 00:06:22 +0200 953)
__git_pretty_aliases ()

Notice the mail is wrong.

And then, 'git send-email' is happy to send such headers. I sent a patch to the list to improve that situation, but looks like sanitize_address() could be improved a lot.

You can blame it on 'git send-email', or 'git blame', or my cccmd script[1], but as I discussed before, this is *precisely* the reason why it would be nice to have an official cccmd script.

Show 9 quoted lines

> You just caught me at the wrong moment when there were much more important
> messages on the list (more refers to the volume, not all of them are more
> important) and I was working on them (not limited to your issue) from top
> to bottom in the mailing list "newsgroup".  I however wanted to get the
> zsh issue resolved sooner, and because you seemed to have been having so
> much trouble with your MUA (I only so 0/4 even for v4), I tried to help
> out by sending what I thought is already good, hoping that a message that
> only has to say "that looks good, thanks" would be easier to make it to
> the list.

I was not nor am I blaming you, I am just saying the situation is ridiculous.

And my MUA is 'git send-email'.

> People say "Oops, our mails crossed." and go on without making too much
> fuss about it.  E-mail communications are asynchronous.  Get used to it.

That's not the problem, but problem is these sanctimonious mail servers that drop mails without warning. And sure, also the code that sends malformed mail.

In any case, fixing 'git blame', and/or 'git send-email', and/or have an official cccmd script, would solve the problem.

Show 8 quoted lines

> I think your mail breakage, from looking at your mail header, is this:
>
>  From: Felipe Contreras <felipe.contreras@gmail.com>
>  To: git@vger.kernel.org
>  Cc: Junio C Hamano <gitster@pobox.com>, SZEDER Gábor <szeder@ira.uka.de>, Jonathan Nieder <jrnieder@gmail.com>, Thomas Rast <trast@inf.ethz.ch>, Felipe Contreras <felipe.contreras@gmail.com>, "Shawn O. Pearce" <spearce@spearce.org>>
>  Subject: [PATCH v4 1/4] completion: work around zsh option propagation bug
>
> Notice the excess '>' after the last address on Cc:?

Thanks for pointing that out :)

> It's not like this is your first serious submission to the list, so it is
> curious why only this time you have been having so much trouble. Perhaps
> you have changed your mail set-up lately?

Yes, people asked me to CC more relevant people, so I enabled by cc-cmd script that I sent to the list long time ago, but didn't receive any more replies, and I also asked if it wouldn't make sense to have an official one [1] -- no replies.

Cheers.

[1] http://article.gmane.org/gmane.comp.version-control.git/189360

-- 
Felipe Contreras