Re: [bug] blame duplicates trailing ">" in mailmapped emails

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 6, 2012, 22:04 UTC
Message-ID: <7vliof62ko.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s1RN+_UK9rAk_m9Z=YaJJtwHLyiCu2stMMDEWqZN9260g@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> This subject doesn't explain the *purpose* of the patch: always return
> a plain mail address from map_user()

That would be a much better subject.

Show 6 quoted lines

> I think the immediate problem should be here:
>
> Currently 'git blame -e' would add an extra '>' if map_user() returns
> true, which would end up as '<foo@bar.com>>'. This is because
> map_user() sometimes modifies, the mail string, but sometimes not. So
> let's always modify it.

That is just a symptom. People who reached this commit by digging the history of mailmap.c would need to see the *cause* of the symptom described in the light of how the API is designed to be used. In other words, "the code after the update has to be this way because these are the i/o constraints this API has". "Otherwise you would see this breakage for example" is merely a supporting material.