Re: [PATCH v3 1/4] completion: be nicer with zsh

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 2, 2012, 19:27 UTC
Message-ID: <7v8vklvxwh.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120202084859.GC3823@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 7 quoted lines

> Felipe Contreras wrote:
>
>> Felipe Contreras (4):
>>   completion: be nicer with zsh
>
> Since I can't find this patch in the mail archive, I'll reply here.
> Luckily the most important bit is above already.

Thanks for playing a mail-relay. Except for the much more readable log message you have here, the result matches what I have at 06357ef (modulo test vs '['). I'll replace what I queued.

Show 7 quoted lines

> I think I mentioned before that this subject line is what will appear
> in the shortlog and the shortlog is all that some people will see of
> the changelog, so it should include a self-contained description of
> the impact of the patch.
>
> However, clearly I did not say it clearly enough. :)  I guess it's
> better to take a cue from storytellers and show rather than tell.

Very big thanks for this ;-)