Re: [PATCH v3 1/4] completion: be nicer with zsh

From: Thomas Rast <trast@inf.ethz.ch>
Date: Feb 2, 2012, 10:35 UTC
Message-ID: <8739at8qw6.fsf@thomas.inf.ethz.ch>
In-Reply-To: <CAMP44s0w1eXWWaMT3WAfLxFHPQvc9dp33cyJ=T2im6g7rsrKhw@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 10 quoted lines

> On Thu, Feb 2, 2012 at 10:48 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>
> Exactly, and "completion: avoid default value assignment on : true
> command" tells *nothing* to most people. Why is this patch needed? Do
> I care about it?
>
> OTOH "completion: be nicer with zsh" explains the purpose of the patch
> and people that don't care about zsh can happily ignore it if they
> want, and the ones that care about zsh might want to back port it, or
> whatever.

Perhaps you could compromise on

  completion: work around zsh word splitting bug in : ${foo:=$(bar)}

> | tl;dr: $__git_porcelain_commands = $__git_all_commands
>
> Wrapping it up, to make clear what happens.

I think this is not good style for a commit message. Apart from the very trendy use of tl;dr, it doesn't even properly summarize the cause *or* the user-visible symptom. It just states how the confusion propagates somewhere in the middle of the code.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch