Re: [bug] blame duplicates trailing ">" in mailmapped emails
- From
Jeff King <peff@peff.net>
- Date
- Feb 6, 2012, 03:03 UTC
- Message-ID
- <20120206030339.GA29123@sigill.intra.peff.net>
- In-Reply-To
- <7vehu8dcc8.fsf@alter.siamese.dyndns.org>
On Sun, Feb 05, 2012 at 04:39:35PM -0800, Junio C Hamano wrote:
Show 13 quoted lines
> > We could also go as far as saying that map_user would _always_ terminate > > in this way (i.e., the caller gets a munged result, whether we found > > anything or not). Then internally, map_user could be simplified to stop > > worrying about making a temporary copy in mailbuf. And callers could > > simply call map_user without worrying about branching on whether it > > found anything or not. > > I thought about it, but such a change needs to audit all the call sites > that assumes the promise original map_user() used to make before it was > broken. If we return 0 to the caller, the caller does not have to worry > about map_user() munging the buffer it lent to it. > > It might be a worthwhile thing to do. I dunno; I didn't look into it.
Ugh, yeah. I was thinking about how it would improve this call site, but I don't want to get into auditing the others. Let's drop it and go with your patch.
-Peff