Re: [PATCH] t0005: skip signal death exit code test on Windows

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 6, 2013, 18:32 UTC
Message-ID: <CAMP44s0Qq2n5cJa9buaLgNDTp61cxA1G+XutTZasphkGmyguHg@mail.gmail.com>
In-Reply-To: <7vy5anyx1w.fsf@alter.siamese.dyndns.org>

On Thu, Jun 6, 2013 at 12:21 PM, Junio C Hamano <gitster@pobox.com> wrote:

> Jeff King <peff@peff.net> writes:

Show 13 quoted lines

>> If somebody wants to write a note somewhere in the git
>> documentation, that's fine with me, but I'm not clear on exactly
>> what it would even say.
>
> I agree with both points.  I can suggest to clarify the log message
> a bit with "the implementation of raise() in msvcrt (Microsoft C
> Runtime library) just calls exit(3)", but that does not address the
> end-user documentation issue.
>
> I tried to summarize the issue for end-user documentation and came
> up with this:
>
>     The Git implementation on MinGW

That's not accurate at all. MinGW is essentially a compiler for Windows. It doesn't matter if you use MinGW, Visual C++, or any other compiler for Windows, the result would be the same.

> But when stated this way, it feels that it belongs to Msysgit
> documentation, not ours, at least to me.

Are we saying then that Git doesn't support Windows? That wouldn't be wise considering it's one of the most widely used reasons to argue that Git is not a good choice of a SCM; lack of Windows support.

The truth of the matter is that exit codes are platform-dependent. Period.

-- 
Felipe Contreras