Re: [PATCH] t0005: skip signal death exit code test on Windows
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Jun 10, 2013, 11:38 UTC
- Message-ID
- <CABPQNSbcAZZ_s7ow4HJ5HenSGSrHLUojqVygokgkQOgjLeDQEQ@mail.gmail.com>
- In-Reply-To
- <51B5648B.7020703@viscovery.net>
On Mon, Jun 10, 2013 at 7:30 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 14 quoted lines
> Am 6/9/2013 22:31, schrieb Junio C Hamano: >> Jeff King <peff@peff.net> writes: >> >>> I'm a little negative on handling just SIGTERM. That would make the test >>> pass, but does it really address the overall issue? To me, the >>> usefulness is having exit values with consistent meanings. >> >> Yes. Unless the goal is to give Windows port pratically the same >> signal semantics as ports on other platforms, I do not think special >> casing SIGTERM (unless it is a very common signal on Windows and >> others are unlikely to be useful) buys us much. > > I'm thinking the same. And, no, SIGTERM is not very common on Windows. >
I have no strong feelings on SIGTERM, but my knee-jerk reaction is the same. AFAIK, the only issue we've seen with it has been this one, which is synthetic.