Re: [PATCH 3/6] revert: fix buffer overflow in insn sheet parser
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Oct 22, 2011, 18:57 UTC
- Message-ID
- <CALkWK0n3srWcsDxaWvgd7s7jHVuSKv+aLJ1n0inae2hMA_C3kQ@mail.gmail.com>
- In-Reply-To
- <7vaa8va3xm.fsf@alter.siamese.dyndns.org>
Hi Junio and Jonathan,
Thanks for the good suggestions. Will post the next iteration in a few minutes (some tests running now).
Junio C Hamano writes:
Show 6 quoted lines
> [...] > When the log message justifies the cause and the approach in the right > way, the actual patch becomes self evident. Also I often find myself > coming up with a _better_ solution than the patch I originally prepared > while writing the commit log message to explain it, and redoing the patch > text to match the description.
Wow. It looks like I have a long way to go :/ Maybe I should practice writing more Haskell.
-- Ram