Re: [PATCH 3/6] revert: fix buffer overflow in insn sheet parser
Hi Jonathan,
Jonathan Nieder writes:
Show 11 quoted lines
> [...]
> Looks good, except I would explain it differently, to avoid referring
> to hypothetical implementation details ("What buffer overflow?"):
>
> test: git cherry-pick --continue should cope with long object names
>
> A naive implementation that uses a commit-id-shaped buffer
> to store the word after "pick" in .git/sequencer/todo lines
> would crash often. Our implementation is not so naive, but
> add a test anyway to futureproof it.
> [...]Show 6 quoted lines
> Though the implementation is actually better than that --- it can even
> cope with a valid object name (e.g., a long name of a branch, or
> something like "HEAD^{/refs.c: ensure struct whose member}") that is
> that long, without truncating it. So if you have time for it, I think
> it would be worth a test where the "git cherry-pick --continue"
> succeeds, too.Good idea. Will re-roll shortly.
Thanks.
-- Ram
Ramkumar Ramachandra <artagnon@gmail.com>