git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/6] revert: fix buffer overflow in insn sheet parser

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 20, 2011, 01:30 UTC
Message-ID
<7v8vogbgai.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1319058208-17923-4-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Check that the commit name argument to a "pick" or "revert" action in
> '.git/sequencer/todo' is not too long, to avoid overflowing an
> on-stack buffer.  This fixes a regression introduced by 5a5d80f4
> (revert: Introduce --continue to continue the operation, 2011-08-04).

Given that this function is going to be fixed properly so that it does not even need to use the "on-stack buffer", is this really necessary?

Previous: Ramkumar RamachandraNext: Jonathan Nieder
Message 5 of 16 in “Sequencer fixups mini-series”
  1. 0/6 Sequencer fixups mini-seriesRamkumar Ramachandra, Oct 19, 2011
  2. 1/6 revert: free msg in format_todo()Ramkumar Ramachandra, Oct 19, 2011
  3. 2/6 revert: simplify getting commit subject in format_todo()Ramkumar Ramachandra, Oct 19, 2011
  4. 3/6 revert: fix buffer overflow in insn sheet parserRamkumar Ramachandra, Oct 19, 2011
  5. Junio C HamanoOct 20, 2011
  6. Jonathan NiederOct 20, 2011
  7. Ramkumar RamachandraOct 20, 2011
  8. Jonathan NiederOct 20, 2011
  9. Ramkumar RamachandraOct 20, 2011
  10. Junio C HamanoOct 20, 2011
  11. Jonathan NiederOct 20, 2011
  12. Junio C HamanoOct 20, 2011
  13. Ramkumar RamachandraOct 22, 2011
  14. 4/6 revert: make commit subjects in insn sheet optionalRamkumar Ramachandra, Oct 19, 2011
  15. 5/6 revert: allow mixed pick and revert instructionsRamkumar Ramachandra, Oct 19, 2011
  16. 6/6 revert: simplify communicating command-line argumentsRamkumar Ramachandra, Oct 19, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.