git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 06/10] commit-graph: move remaining write parameters into options

From
Kristofer Karlsson <krka@spotify.com>
Date
Nov 5, 2026, 15:07 UTC
Message-ID
<CAL71e4PxNKffAmmB2XbV8mksUe_nJ9uS2JQhpbm2X1jtG=z9SQ@mail.gmail.com>
In-Reply-To
<auyCsmn6Hx_uc6zq@pks.im>
On Thu, 5 Nov 2026 at 14:21, Patrick Steinhardt <ps@pks.im> wrote:
Show 5 quoted lines
>
> I was wondering whether we want to maybe introduce a tagged union where
> it becomes implicitly clear that some of the options only apply to a
> specific mode. Something like this:
>
[...]
Show 5 quoted lines
>
> I wasn't really sure whether that complexity is really worth it, so for
> now I decided to not pursue it. I think I still tend to stick with that
> decision for now, but it's maybe something to keep in mind for the
> future?

Yes, I agree that it's already clean enough. If this code ever moves to Rust, an enum with the relevant data would be nice though.

Thanks, Kristofer

Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 13 of 22 in “commit-graph: several refactorings for writing commit graphs”
  1. 00/10 commit-graph: several refactorings for writing commit graphsPatrick Steinhardt, Nov 4, 2026
  2. 01/10 commit-graph: rename `struct commit_graph_opts`Patrick Steinhardt, Nov 4, 2026
  3. 02/10 commit-graph: pass writer flags via optionsPatrick Steinhardt, Nov 4, 2026
  4. 03/10 commit-graph: drop `NULL` checks for write optionsPatrick Steinhardt, Nov 4, 2026
  5. 04/10 commit-graph: drop redundant flags in write contextPatrick Steinhardt, Nov 4, 2026
  6. Junio C HamanoNov 4, 2026
  7. 05/10 commit-graph: merge the two commit graph writersPatrick Steinhardt, Nov 4, 2026
  8. Derrick StoleeNov 4, 2026
  9. 06/10 commit-graph: move remaining write parameters into optionsPatrick Steinhardt, Nov 4, 2026
  10. Derrick StoleeNov 4, 2026
  11. Kristofer KarlssonNov 4, 2026
  12. Patrick SteinhardtNov 5, 2026
  13. Kristofer KarlssonNov 5, 2026
  14. 07/10 commit-graph: fix mixup of write/verify flagsPatrick Steinhardt, Nov 4, 2026
  15. 08/10 builtin/commit-graph: set flags directlyPatrick Steinhardt, Nov 4, 2026
  16. 09/10 odb/source-files: verify commit-graphs as part of fsckPatrick Steinhardt, Nov 4, 2026
  17. 10/10 commit-graph: modernize function namesPatrick Steinhardt, Nov 4, 2026
  18. Derrick StoleeNov 4, 2026
  19. Patrick SteinhardtNov 5, 2026
  20. Patrick SteinhardtNov 5, 2026
  21. Derrick StoleeNov 5, 2026
  22. Patrick SteinhardtNov 5, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.