Re: [PATCH 06/10] commit-graph: move remaining write parameters into options
- From
Kristofer Karlsson <krka@spotify.com>
- Date
- Nov 5, 2026, 15:07 UTC
- Message-ID
- <CAL71e4PxNKffAmmB2XbV8mksUe_nJ9uS2JQhpbm2X1jtG=z9SQ@mail.gmail.com>
- In-Reply-To
- <auyCsmn6Hx_uc6zq@pks.im>
On Thu, 5 Nov 2026 at 14:21, Patrick Steinhardt <ps@pks.im> wrote:
Show 5 quoted lines
> > I was wondering whether we want to maybe introduce a tagged union where > it becomes implicitly clear that some of the options only apply to a > specific mode. Something like this: >
[...]
Show 5 quoted lines
> > I wasn't really sure whether that complexity is really worth it, so for > now I decided to not pursue it. I think I still tend to stick with that > decision for now, but it's maybe something to keep in mind for the > future?
Yes, I agree that it's already clean enough. If this code ever moves to Rust, an enum with the relevant data would be nice though.
Thanks, Kristofer