Re: [PATCH 06/10] commit-graph: move remaining write parameters into options
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Nov 4, 2026, 16:34 UTC
- Message-ID
- <57322050-95b1-4faf-ae59-30a355d90355@gmail.com>
- In-Reply-To
- <20261104-pks-commit-graph-write-refactorings-v1-6-d013d9401a59@pks.im>
On 11/4/2026 10:57 AM, Patrick Steinhardt wrote:
> Move the remaining optional parameters that can be passed to > `write_commit_graph()` into its options structure to simplify the > function's calling convention.
Show 6 quoted lines
> - if (write_commit_graph(repo, dir->abspath, > - opts.stdin_packs ? &pack_indexes : NULL, > - opts.stdin_commits ? &commits : NULL, > - &write_opts)) > + if (write_commit_graph(repo, dir->abspath, &write_opts)) > result = 1;
So much cleaner! (Even better in other hunks.)
Thanks, -Stolee